----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55318/#review181640 -----------------------------------------------------------
3rdparty/libprocess/src/poll_socket.cpp Lines 192-197 (original), 198-203 (patched) <https://reviews.apache.org/r/55318/#comment257266> Hm.. what happened here? Previously we treat is_restartable as being interrupted, and we don't trip back through poll, but in your change, we treat it the same as retryable and we trip back through poll. This distinction is lost in your change, was this intentional? 3rdparty/libprocess/src/poll_socket.cpp Lines 239-257 (original), 244-248 (patched) <https://reviews.apache.org/r/55318/#comment257267> Ditto here. - Benjamin Mahler On Jan. 8, 2017, 7:44 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55318/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2017, 7:44 a.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Used loop in PollSocketImpl. > > > Diffs > ----- > > 3rdparty/libprocess/src/poll_socket.cpp > 5410b07e7b2ba5de4c1b61f358b6bcb224012eda > > > Diff: https://reviews.apache.org/r/55318/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
