-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61179/#review181726
-----------------------------------------------------------


Fix it, then Ship it!





src/internal/devolve.hpp
Lines 69 (patched)
<https://reviews.apache.org/r/61179/#comment257377>

    move this right above `SlaveID` one (alphebical?)



src/internal/devolve.cpp
Lines 157 (patched)
<https://reviews.apache.org/r/61179/#comment257378>

    Ditto on order.


- Jie Yu


On July 27, 2017, 2:49 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61179/
> -----------------------------------------------------------
> 
> (Updated July 27, 2017, 2:49 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit adds the default overload to 'devolve'
> 'ResourceProviderID's.
> 
> 
> Diffs
> -----
> 
>   src/internal/devolve.hpp 656173de0a652431be3c3c3d3796e3f3f7fca278 
>   src/internal/devolve.cpp 7eb58e94beb5262a63e2f9b9dfefbd3d288e32ec 
> 
> 
> Diff: https://reviews.apache.org/r/61179/diff/1/
> 
> 
> Testing
> -------
> 
> Tested as part of https://reviews.apache.org/r/61182/.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Reply via email to