----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61222/#review182055 -----------------------------------------------------------
Thanks for addressing this tech debt! Looks good for the most part. Can you split the test into a separate review? src/master/http.cpp Lines 3791-3823 (patched) <https://reviews.apache.org/r/61222/#comment257873> Can this code be shared with the original `teardown()` method of the old API to avoid duplication? - Anand Mazumdar On July 28, 2017, 5:38 p.m., Quinn Leng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61222/ > ----------------------------------------------------------- > > (Updated July 28, 2017, 5:38 p.m.) > > > Review request for mesos, Anand Mazumdar and Greg Mann. > > > Bugs: MESOS-6846 > https://issues.apache.org/jira/browse/MESOS-6846 > > > Repository: mesos > > > Description > ------- > > Added V1 call support for the teardown operation. Added test cases > for the V1 teardown call. > > > Diffs > ----- > > include/mesos/master/master.proto 7a722a6deac484f28a85f63fd68ef49cb6a47606 > include/mesos/v1/master/master.proto > cf88ea64fa08e4bdcf685de4def28d374eb32fdf > src/master/http.cpp 9df086c417a9392f62d600c7a6486be0a1cf7e70 > src/master/master.hpp 84465af782d4024f22463d981ef9d0ef7827d043 > src/master/validation.cpp 4885339b2112b6dbdc930875c20e1f5872b1edbf > src/tests/api_tests.cpp f22ca28c819712d8797e0c0c69dc1ebf1fe5ac1f > > > Diff: https://reviews.apache.org/r/61222/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Quinn Leng > >
