----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61222/#review182640 -----------------------------------------------------------
src/master/http.cpp Lines 3766-3777 (original), 3776-3785 (patched) <https://reviews.apache.org/r/61222/#comment258620> Let's replace this code with ``` return __teardown(id); ``` and rename the original `_teardown()` continuation to `__teardown()`. This will let us avoid duplicating the `master->removeFramework` call. - Greg Mann On Aug. 3, 2017, 5:56 p.m., Quinn Leng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61222/ > ----------------------------------------------------------- > > (Updated Aug. 3, 2017, 5:56 p.m.) > > > Review request for mesos, Anand Mazumdar and Greg Mann. > > > Bugs: MESOS-6846 > https://issues.apache.org/jira/browse/MESOS-6846 > > > Repository: mesos > > > Description > ------- > > Added V1 call support for teardown operation. > > > Diffs > ----- > > include/mesos/master/master.proto 0e4c30e3df704a929a3bd2e1787a76421d14a983 > include/mesos/v1/master/master.proto > c04fd1602396a58086331f5fa56518c5dee9af89 > src/master/http.cpp 9df086c417a9392f62d600c7a6486be0a1cf7e70 > src/master/master.hpp 84465af782d4024f22463d981ef9d0ef7827d043 > src/master/validation.cpp 4885339b2112b6dbdc930875c20e1f5872b1edbf > > > Diff: https://reviews.apache.org/r/61222/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > Quinn Leng > >
