> On Aug. 4, 2017, 10:58 a.m., Benjamin Bannier wrote:
> > src/tests/containerizer/posix_rlimits_isolator_tests.cpp
> > Lines 449 (patched)
> > <https://reviews.apache.org/r/61387/diff/2/?file=1789190#file1789190line449>
> >
> > It would be nice to avoid hardcoding `4` here, e.g.,
> >
> > foreach (Future<TaskStatus> update, updates) {
> > EXPECT_CALL(sched, statusUpdate(&driver, _))
> > .WillOnce(FutureArg<1>(&update));
> > }
Dropped a ref here,
foreach (Future<TaskStatus>& update, updates) {
EXPECT_CALL(sched, statusUpdate(&driver, _))
.WillOnce(FutureArg<1>(&update));
}
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61387/#review182189
-----------------------------------------------------------
On Aug. 4, 2017, 12:10 a.m., Gastón Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61387/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2017, 12:10 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Jie Yu.
>
>
> Bugs: MESOS-7849
> https://issues.apache.org/jira/browse/MESOS-7849
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Make the rlimits isolator support nesting. Without this patch rlimits
> sets for tasks launched by the DefaultExecutor are silently ignored.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/posix/rlimits.hpp
> ee36a24ae36179d3ff3141f8c3cdc768b1e399af
> src/slave/containerizer/mesos/isolators/posix/rlimits.cpp
> 3fc2b3dbd5b382e422c948adae0dc50f4fbcfc49
> src/tests/containerizer/posix_rlimits_isolator_tests.cpp
> b7ccc7eeeb7e4d0d8f4fd463d506cfe7157076a4
>
>
> Diff: https://reviews.apache.org/r/61387/diff/2/
>
>
> Testing
> -------
>
> `bin/mesos-tests.sh
> --gtest_filter="PosixRLimitsIsolatorTest.NestedContainers"
> --gtest_repeat=1000 --gtest_break_on_failure` passed on a machine running
> GNU/Linux.
>
>
> Thanks,
>
> Gastón Kleiman
>
>
