----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61387/#review182240 -----------------------------------------------------------
Ship it! Ship It! - Jie Yu On Aug. 4, 2017, 9:15 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61387/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2017, 9:15 p.m.) > > > Review request for mesos, Benjamin Bannier and Jie Yu. > > > Bugs: MESOS-7849 > https://issues.apache.org/jira/browse/MESOS-7849 > > > Repository: mesos > > > Description > ------- > > Make the rlimits isolator support nesting. Without this patch rlimits > sets for tasks launched by the DefaultExecutor are silently ignored. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/posix/rlimits.hpp > ee36a24ae36179d3ff3141f8c3cdc768b1e399af > src/slave/containerizer/mesos/isolators/posix/rlimits.cpp > 3fc2b3dbd5b382e422c948adae0dc50f4fbcfc49 > src/tests/containerizer/posix_rlimits_isolator_tests.cpp > b7ccc7eeeb7e4d0d8f4fd463d506cfe7157076a4 > > > Diff: https://reviews.apache.org/r/61387/diff/4/ > > > Testing > ------- > > `bin/mesos-tests.sh > --gtest_filter="PosixRLimitsIsolatorTest.NestedContainers" > --gtest_repeat=1000 --gtest_break_on_failure` passed on a machine running > GNU/Linux. > > > Thanks, > > Gastón Kleiman > >
