----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61428/#review182248 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/namespaces/pid.cpp Lines 85-86 (patched) <https://reviews.apache.org/r/61428/#comment258142> I know in proto2 and proto3 `boolean` defaults to be `false`. But how about `optional bool`? do you know if `has_share_pid_namespace` can be false? - Gilbert Song On Aug. 4, 2017, 9:39 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61428/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2017, 9:39 a.m.) > > > Review request for mesos, Gastón Kleiman, Gilbert Song, Jie Yu, Kevin Klues, > and Vinod Kone. > > > Bugs: MESOS-7853 > https://issues.apache.org/jira/browse/MESOS-7853 > > > Repository: mesos > > > Description > ------- > > Added pid ns sharing based on agent flag and protobuf message field. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/namespaces/pid.hpp > 2b316dbdf4a3735771af5bed80c6251d0d1cbd50 > src/slave/containerizer/mesos/isolators/namespaces/pid.cpp > f1dfc9f7398ffc029d7180d7f014a515338cb3f4 > > > Diff: https://reviews.apache.org/r/61428/diff/2/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
