-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61434/#review182495
-----------------------------------------------------------




docs/health-checks.md
Line 29 (original), 29 (patched)
<https://reviews.apache.org/r/61434/#comment258403>

    s/defines/which defines?



docs/health-checks.md
Lines 162 (patched)
<https://reviews.apache.org/r/61434/#comment258408>

    s/the following/to the following?



docs/health-checks.md
Lines 204 (patched)
<https://reviews.apache.org/r/61434/#comment258410>

    I think we also need to mention that the expectation here is that task is 
listening on the `loopback` interface along with any other routeable interface 
to which it might be listening.



docs/health-checks.md
Lines 208 (patched)
<https://reviews.apache.org/r/61434/#comment258409>

    how is the `host` resolved? It's not necessary that it will resolve to 
`127.0.0.1`?



docs/health-checks.md
Lines 232 (patched)
<https://reviews.apache.org/r/61434/#comment258411>

    Ditto to the comments on the `HTTP Checks` section.



docs/health-checks.md
Line 265 (original), 494 (patched)
<https://reviews.apache.org/r/61434/#comment258412>

    Why do we need to share the `mnt` namespace? This is already done by the 
executor for `MesosContainerizer` so why does the `checker` need to do this if 
it is running as part of the executor?



docs/health-checks.md
Line 267 (original), 496 (patched)
<https://reviews.apache.org/r/61434/#comment258413>

    A bit confused here? I thought only `Health checks` are supported for 
`docker executor` and not `checks`?


- Avinash sridharan


On Aug. 4, 2017, 6:14 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61434/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2017, 6:14 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-7349
>     https://issues.apache.org/jira/browse/MESOS-7349
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/health-checks.md d0749347d1f9398004e56b03503d655b5fba75f4 
> 
> 
> Diff: https://reviews.apache.org/r/61434/diff/1/
> 
> 
> Testing
> -------
> 
> https://gist.github.com/rukletsov/517a136cb6a0e8b909db30b36b13eded
> 
> Additionally rendered in MacDown.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Reply via email to