> On Aug. 9, 2017, 5:30 p.m., Avinash sridharan wrote: > > docs/health-checks.md > > Line 29 (original), 29 (patched) > > <https://reviews.apache.org/r/61434/diff/1/?file=1789488#file1789488line29> > > > > s/defines/which defines?
It was intended as a simple enumeration. > On Aug. 9, 2017, 5:30 p.m., Avinash sridharan wrote: > > docs/health-checks.md > > Lines 208 (patched) > > <https://reviews.apache.org/r/61434/diff/1/?file=1789488#file1789488line208> > > > > how is the `host` resolved? It's not necessary that it will resolve to > > `127.0.0.1`? Yes, we do not resolve anything. I'll reword to "set". > On Aug. 9, 2017, 5:30 p.m., Avinash sridharan wrote: > > docs/health-checks.md > > Line 267 (original), 496 (patched) > > <https://reviews.apache.org/r/61434/diff/1/?file=1789488#file1789488line519> > > > > A bit confused here? I thought only `Health checks` are supported for > > `docker executor` and not `checks`? Right, but health checks are using checks underneath. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61434/#review182495 ----------------------------------------------------------- On Aug. 4, 2017, 6:14 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61434/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2017, 6:14 p.m.) > > > Review request for mesos, Gastón Kleiman, Greg Mann, and Vinod Kone. > > > Bugs: MESOS-7349 > https://issues.apache.org/jira/browse/MESOS-7349 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > docs/health-checks.md d0749347d1f9398004e56b03503d655b5fba75f4 > > > Diff: https://reviews.apache.org/r/61434/diff/1/ > > > Testing > ------- > > https://gist.github.com/rukletsov/517a136cb6a0e8b909db30b36b13eded > > Additionally rendered in MacDown. > > > Thanks, > > Alexander Rukletsov > >
