> On Aug. 11, 2017, 11:02 a.m., Benjamin Bannier wrote: > > support/apply-reviews.py > > Line 364 (original), 371-373 (patched) > > <https://reviews.apache.org/r/61588/diff/1/?file=1795426#file1795426line371> > > > > Since this prevents running any (pre-)commit hooks, I wonder if we > > should give this a more general name, e.g., simply expose > > `[-n|--no-verify]`. > > Chun-Hung Hsiao wrote: > If we use `--no-verify` a the long option, then the short option `-n` > would conflict with `--no-amend`, and it seems to me that we should not > change what's already there. And `-v` looks like `--verbose` and also not > obvious to see it's *not* doing a verification. Keviv and I looked through > the keyboard and came up with this one.
Good point about collisions. What about e.g., `[-s|--skip-commit-hooks]` or even `[-s|--skip-hooks]`? If I had a precommit hook invoking `clang-format` this flag would also disable it. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61588/#review182670 ----------------------------------------------------------- On Aug. 11, 2017, 1:41 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61588/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2017, 1:41 a.m.) > > > Review request for mesos, Benjamin Bannier, Jie Yu, and Kevin Klues. > > > Bugs: MESOS-7880 > https://issues.apache.org/jira/browse/MESOS-7880 > > > Repository: mesos > > > Description > ------- > > Added a `--skip-style-check` option when applying reviews. > > > Diffs > ----- > > support/apply-reviews.py aa2eb8d23bed52a4f33510c53ace2c63bd66ec49 > > > Diff: https://reviews.apache.org/r/61588/diff/1/ > > > Testing > ------- > > > Thanks, > > Chun-Hung Hsiao > >
