----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61588/#review182742 -----------------------------------------------------------
Fix it, then Ship it! Thanks for the patch. I am sure this will be very useful for e.g., reviewing patches currently not passing the our linters. support/apply-reviews.py Lines 263-266 (original), 269-273 (patched) <https://reviews.apache.org/r/61588/#comment258731> This line extends beyond 80 chars. Let's wrap it to not undo already done work for MESOS-6390, e.g., cmd = u"git commit "\ "--author \"{author}\" "\ "{amend} -aF \"{message}\" {verify}".format( author=quote(data['author']), amend=amend, message=message_file, verify=verify) (We seem to prefer C-style continuations to the more usual triple quotes). Note how the args to `format` are indented by 4 spaces relative to the wrapped string. To check if the format passes the still not enabled linting of support Python scripts, add `support` to `PyLinter`'s `source_dirs` in `support/mesos-style.py`, and run it on the file. - Benjamin Bannier On Aug. 11, 2017, 8:45 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61588/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2017, 8:45 p.m.) > > > Review request for mesos, Benjamin Bannier, Jie Yu, and Kevin Klues. > > > Bugs: MESOS-7880 > https://issues.apache.org/jira/browse/MESOS-7880 > > > Repository: mesos > > > Description > ------- > > Added a `[-s|--skip-hooks]` option when applying reviews. > > > Diffs > ----- > > support/apply-reviews.py aa2eb8d23bed52a4f33510c53ace2c63bd66ec49 > > > Diff: https://reviews.apache.org/r/61588/diff/2/ > > > Testing > ------- > > > Thanks, > > Chun-Hung Hsiao > >
