> On Aug. 11, 2017, 6:32 p.m., Greg Mann wrote: > > 3rdparty/stout/tests/duration_tests.cpp > > Lines 65 (patched) > > <https://reviews.apache.org/r/60721/diff/4/?file=1787920#file1787920line65> > > > > Why the newline?
woops, I did it again. - Gastón ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60721/#review182728 ----------------------------------------------------------- On Aug. 12, 2017, 1:02 a.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60721/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2017, 1:02 a.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Greg Mann, > and Vinod Kone. > > > Bugs: MESOS-7661 > https://issues.apache.org/jira/browse/MESOS-7661 > > > Repository: mesos > > > Description > ------- > > Made `Duration:parse()` return an error if the argument is out of the > range that a `Duration` can represent. > > > Diffs > ----- > > 3rdparty/stout/include/stout/duration.hpp > b0cd77b833f6fbf752b4db820fd43b87e1d1e476 > 3rdparty/stout/tests/duration_tests.cpp > 59b08f14849a8db31f11fbd0b2e1248c99afd9dd > > > Diff: https://reviews.apache.org/r/60721/diff/5/ > > > Testing > ------- > > Added a new expectation to an existing test and confirmed that tests still > pass. > > > Thanks, > > Gastón Kleiman > >
