----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61705/#review183195 -----------------------------------------------------------
Fix it, then Ship it! src/tests/csi_client_tests.cpp Lines 50 (patched) <https://reviews.apache.org/r/61705/#comment259212> instead of using `pair`, i'd prefer an explicit struct to make it more readable: ``` struct RPC { string name; lambda::function<Future<Nothing>(const string&)> call; }; class CSIClientTest : public TemporaryDirectoryTest, public WithParamInterface<RPC> { ... }; ``` src/tests/csi_client_tests.cpp Lines 104 (patched) <https://reviews.apache.org/r/61705/#comment259210> 2 lines apart. src/tests/csi_client_tests.cpp Lines 140 (patched) <https://reviews.apache.org/r/61705/#comment259211> `{` in the next line. - Jie Yu On Aug. 16, 2017, 11:13 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61705/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2017, 11:13 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: mesos-7491 > https://issues.apache.org/jira/browse/mesos-7491 > > > Repository: mesos > > > Description > ------- > > The mock plugin simply starts the `Identity`, `Controller` and `Node` > CSI services and return a success with an empty response protocol buffer > for each RPC. The unit test verifies that each method in the CSI client > classes makes the corresponding RPC call through the gRPC interface in > libprocess. > > > Diffs > ----- > > src/tests/csi_client_tests.cpp PRE-CREATION > src/tests/mock_csi_plugin.hpp PRE-CREATION > src/tests/mock_csi_plugin.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/61705/diff/1/ > > > Testing > ------- > > Tests described in r/61706. > > > Thanks, > > Chun-Hung Hsiao > >
