----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61705/#review183517 -----------------------------------------------------------
Ship it! Ship It! - Jie Yu On Aug. 19, 2017, 12:37 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61705/ > ----------------------------------------------------------- > > (Updated Aug. 19, 2017, 12:37 a.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: mesos-7491 > https://issues.apache.org/jira/browse/mesos-7491 > > > Repository: mesos > > > Description > ------- > > The mock plugin simply starts the `Identity`, `Controller` and `Node` > CSI services and return a success with an empty response protocol buffer > for each RPC. The unit test verifies that each method in the `Client` > class makes the corresponding RPC call through the gRPC interface in > libprocess. > > > Diffs > ----- > > src/tests/csi_client_tests.cpp PRE-CREATION > src/tests/mock_csi_plugin.hpp PRE-CREATION > src/tests/mock_csi_plugin.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/61705/diff/2/ > > > Testing > ------- > > Tests described in r/61706. > > > Thanks, > > Chun-Hung Hsiao > >
