----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61733/#review183228 -----------------------------------------------------------
include/mesos/v1/master/master.proto Line 362 (original), 362 (patched) <https://reviews.apache.org/r/61733/#comment259251> Is there any documentation around our deprecation cycles? I kind of understand that these pubic promises should be handled with very long deprecation but why a 2.0 and not a 1.2 + N (e.g. 3). We need to be clear and have this publically documented I believe. If there was no JIRA around it, we should create one. include/mesos/v1/master/master.proto Line 377 (original), 377 (patched) <https://reviews.apache.org/r/61733/#comment259250> Why did the start of deprecation period version change here? include/mesos/v1/master/master.proto Line 410 (original), 409 (patched) <https://reviews.apache.org/r/61733/#comment259253> See above - kinda confusing. Guessing that you have simply made it consistant with unversioned but we should double-check with the maintainers here, I feel. - Till Toenshoff On Aug. 18, 2017, 1:32 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61733/ > ----------------------------------------------------------- > > (Updated Aug. 18, 2017, 1:32 p.m.) > > > Review request for mesos, Anand Mazumdar and Till Toenshoff. > > > Repository: mesos > > > Description > ------- > > Synchronized comment in v1 and unversioned master.proto. > > > Diffs > ----- > > include/mesos/v1/master/master.proto > c3fb31de2509adcdec8204f8bbe46b46a31540e8 > > > Diff: https://reviews.apache.org/r/61733/diff/1/ > > > Testing > ------- > > > Thanks, > > Kapil Arya > >
