> On Aug. 18, 2017, 2:39 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 362 (patched) > > <https://reviews.apache.org/r/60496/diff/11/?file=1799820#file1799820line363> > > > > I see you put the actual used resources (i.e. unallocated ports) here, > > however I am a bit confused if we should do it or should put the requested > > resources (allocated ports) here. In > > `PosixDiskIsolatorProcess::_collect()`, it seems we use the requested > > resource (disk quota), but in `MemorySubsystem::oomWaited()`, it seems we > > use the actual used resources. > > > > I think what you did here is correct, so we may need to update the code > > of `PosixDiskIsolatorProcess::_collect()`?
Let's not update any other isolators in this review chain. I think in the case of the other isolators, it doesn't matter how much you exceed the resource by so it's not that important how the resource is reported. This isolator is a litle different because reporting the rogue ports is helpful for diagnostics. - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60496/#review183190 ----------------------------------------------------------- On Aug. 17, 2017, 5:36 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60496/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2017, 5:36 p.m.) > > > Review request for mesos, Qian Zhang and Jiang Yan Xu. > > > Bugs: MESOS-7675 > https://issues.apache.org/jira/browse/MESOS-7675 > > > Repository: mesos > > > Description > ------- > > Implemented ports resource restrictions in the network ports isolator. > Periodically, scan for listening sockets and match them up to all > the open sockets in the containers we are tracking in the network. > Check any sockets we find against the ports resource and trigger a > resource limitation if the port has not been allocated. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/ports.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/network/ports.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/60496/diff/11/ > > > Testing > ------- > > make check (Fedora 26) > > > Thanks, > > James Peach > >
