----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61766/#review183332 -----------------------------------------------------------
src/checks/checker_process.cpp Lines 913-920 (original), 913-920 (patched) <https://reviews.apache.org/r/61766/#comment259370> Let's print stderr regardless of the retcode, what you now do with the command checks. It is probably not much value to do so here, but it is _consistent_ : ). src/checks/checker_process.cpp Lines 916-919 (original), 916-919 (patched) <https://reviews.apache.org/r/61766/#comment259371> Looking at this, I'm not sure we should return a failure here: `stderr` is not critical for getting the HTTP code, so maybe log warning here? This is also consistent with what you now do for nested command checks. src/checks/checker_process.cpp Lines 1071-1076 (original), 1075-1080 (patched) <https://reviews.apache.org/r/61766/#comment259369> Let's print it regardless of the retcode, what you now do with the command checks. It is probably not much value to do so for the tcp checker, but it is _consistent_ : ). - Alexander Rukletsov On Aug. 19, 2017, 12:27 a.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61766/ > ----------------------------------------------------------- > > (Updated Aug. 19, 2017, 12:27 a.m.) > > > Review request for mesos, Alexander Rukletsov, Greg Mann, and Vinod Kone. > > > Bugs: MESOS-7861 > https://issues.apache.org/jira/browse/MESOS-7861 > > > Repository: mesos > > > Description > ------- > > Made the output handling of TCP and HTTP checks consistent. > > > Diffs > ----- > > src/checks/checker_process.cpp 30dda0e6efca31aa6b9cd4f753f96b979717ab2e > > > Diff: https://reviews.apache.org/r/61766/diff/1/ > > > Testing > ------- > > `make tests` on GNU/Linux > > > Thanks, > > Gastón Kleiman > >
