> On Aug. 21, 2017, 1:46 p.m., Alexander Rukletsov wrote: > > src/checks/checker_process.cpp > > Lines 921-924 (original), 921-924 (patched) > > <https://reviews.apache.org/r/61766/diff/1/?file=1800336#file1800336line921> > > > > Additionally `VLOG(1)` stderr?
This failure message will be printed by the executor and it includes the stderr output, so I think this is sufficient? - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61766/#review183336 ----------------------------------------------------------- On Aug. 19, 2017, 12:27 a.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61766/ > ----------------------------------------------------------- > > (Updated Aug. 19, 2017, 12:27 a.m.) > > > Review request for mesos, Alexander Rukletsov, Greg Mann, and Vinod Kone. > > > Bugs: MESOS-7861 > https://issues.apache.org/jira/browse/MESOS-7861 > > > Repository: mesos > > > Description > ------- > > Made the output handling of TCP and HTTP checks consistent. > > > Diffs > ----- > > src/checks/checker_process.cpp 30dda0e6efca31aa6b9cd4f753f96b979717ab2e > > > Diff: https://reviews.apache.org/r/61766/diff/1/ > > > Testing > ------- > > `make tests` on GNU/Linux > > > Thanks, > > Gastón Kleiman > >
