----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61260/#review183385 -----------------------------------------------------------
Can we cover the failure case in the tests? e.g., `GarbageCollectorIntegrationTest.ROOT_BusyMountPoint`? src/slave/gc.cpp Lines 72 (patched) <https://reviews.apache.org/r/61260/#comment259409> Can we add a simple comment on why `await()` is used? e.g., ``` // Make sure the gauge is not accessed after the destruction of `gc`. ``` src/slave/gc.cpp Lines 196-198 (patched) <https://reviews.apache.org/r/61260/#comment259408> IIRC from your slack chat with @mpark this (unable to use `mutable`) is a regression and it should be fixed soon? If so can we make sure a JIRA is filed and a TODO that references it is added here? - Jiang Yan Xu On Aug. 10, 2017, 3 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61260/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2017, 3 p.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-7842 > https://issues.apache.org/jira/browse/MESOS-7842 > > > Repository: mesos > > > Description > ------- > > Added some basic sandbox garbage collection metrics to track the number > of paths removals, the number of failed path removal and the number of > paths that are still scheduled for removal. > > > Diffs > ----- > > src/slave/gc.cpp f270fa47b22904e926f4bd4b0a7693a41b2c8271 > src/slave/gc_process.hpp PRE-CREATION > src/tests/gc_tests.cpp d4daad3993bb9a92db2c7add6e74f12aeb71d535 > > > Diff: https://reviews.apache.org/r/61260/diff/2/ > > > Testing > ------- > > make check (Fedora 26). > > > Thanks, > > James Peach > >
