> On Aug. 22, 2017, 11 a.m., Jiang Yan Xu wrote: > > src/slave/gc.cpp > > Lines 53 (patched) > > <https://reviews.apache.org/r/61260/diff/3/?file=1801592#file1801592line53> > > > > Actually, it didn't occur to me earlier but a better naming pattern > > would probably be: > > > > ``` > > gc/path_removals_succeeded > > gc/path_removals_failed > > gc/path_removals_pending > > ``` > > > > `slave/` would imply these are metrics from the `Slave` actor which is > > not true.
Sorry "actor" is not strictly the criteria for namespacing metrics. It should be just as what is it: a namespace, e.g., on the master there are metrics such as `frameworks/<framework_principal>/messages_processed`. Probably not worth overthinking this, this is just me suggesting shorten the name while still keep them clearly grouped/namespaced. - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61260/#review183498 ----------------------------------------------------------- On Aug. 22, 2017, 8:51 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61260/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2017, 8:51 a.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-7842 > https://issues.apache.org/jira/browse/MESOS-7842 > > > Repository: mesos > > > Description > ------- > > Added some basic sandbox garbage collection metrics to track the number > of paths removals, the number of failed path removal and the number of > paths that are still scheduled for removal. > > > Diffs > ----- > > src/slave/gc.cpp f270fa47b22904e926f4bd4b0a7693a41b2c8271 > src/slave/gc_process.hpp PRE-CREATION > src/tests/gc_tests.cpp d4daad3993bb9a92db2c7add6e74f12aeb71d535 > > > Diff: https://reviews.apache.org/r/61260/diff/3/ > > > Testing > ------- > > make check (Fedora 26). > > > Thanks, > > James Peach > >
