----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60766/#review183693 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/network/ports.cpp Line 406 (original), 451 (patched) <https://reviews.apache.org/r/60766/#comment259758> Can we put all nested containers in a list in the above `foreach` loop so that we do not have to go through all containers here? src/slave/containerizer/mesos/isolators/network/ports.cpp Lines 462 (patched) <https://reviews.apache.org/r/60766/#comment259759> I think it should be `if (infos.contains(rootContainerId)) {`. src/slave/containerizer/mesos/isolators/network/ports.cpp Lines 490 (patched) <https://reviews.apache.org/r/60766/#comment259761> Kill this empty line. - Qian Zhang On Aug. 22, 2017, 6:01 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60766/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2017, 6:01 a.m.) > > > Review request for mesos, Qian Zhang and Jiang Yan Xu. > > > Bugs: MESOS-7675 > https://issues.apache.org/jira/browse/MESOS-7675 > > > Repository: mesos > > > Description > ------- > > Working on the assumption that containers with CNI networks will > get their own IP addresses and don't need port isolation, ignore > any containers that are joining CNI networks. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp > 5805dfb4fb6e755e4c23851b0a6b504f2a8b3396 > src/slave/containerizer/mesos/isolators/network/ports.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/network/ports.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/60766/diff/13/ > > > Testing > ------- > > make check (Fedora 26). > > > Thanks, > > James Peach > >
