----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58021/#review183971 -----------------------------------------------------------
src/common/protobuf_utils.cpp Line 442 (original), 442 (patched) <https://reviews.apache.org/r/58021/#comment260009> I'd see if we can avoid changing `inject` to different methods based on the type. See if something like the following will work or not: ``` struct Injector { void operator()( Resource& resource, const Reosurce::AllocationInfo& allocationInfo) { ... } void operator()( RepeatedPtrField<Resource>* resources, const Reosurce::AllocationInfo& allocationInfo) { ... } } inject; ``` - Jie Yu On Aug. 8, 2017, 8:21 a.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58021/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2017, 8:21 a.m.) > > > Review request for mesos, Benjamin Bannier and Jie Yu. > > > Bugs: MESOS-7314 > https://issues.apache.org/jira/browse/MESOS-7314 > > > Repository: mesos > > > Description > ------- > > Added storage-related offer operations. > > > Diffs > ----- > > include/mesos/mesos.proto f31f5bdc2ace2b261885b252e7c01ceb9b76c461 > include/mesos/v1/mesos.proto 66386a84bc21989d1c1237e629d5d04662a368fa > src/common/protobuf_utils.cpp 3ae68e93a985a4cfe23be9c9bd8f92e418102a39 > src/common/resources.cpp 8d4388935ada6be60448e6f6a88db0e5fc4ad4a1 > src/common/resources_utils.cpp 821bd0967d55f7fbcb57a4efae5fc390af53ca79 > src/master/master.cpp 7f38a5e21884546d4b4c866ca5918db779af8f99 > src/v1/resources.cpp 508f3f85c8388a41f57f964b0f6df3b4708d3442 > > > Diff: https://reviews.apache.org/r/58021/diff/5/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
