> On Aug. 31, 2017, 4:14 a.m., Jie Yu wrote: > > src/common/protobuf_utils.cpp > > Lines 532-538 (original), 574-584 (patched) > > <https://reviews.apache.org/r/58021/diff/6/?file=1806578#file1806578line575> > > > > Can you change this too? like what we did for inject?
Oh, of course. Not sure how I could miss that. - Jan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58021/#review184228 ----------------------------------------------------------- On Aug. 29, 2017, 3:23 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58021/ > ----------------------------------------------------------- > > (Updated Aug. 29, 2017, 3:23 p.m.) > > > Review request for mesos, Benjamin Bannier and Jie Yu. > > > Bugs: MESOS-7314 > https://issues.apache.org/jira/browse/MESOS-7314 > > > Repository: mesos > > > Description > ------- > > Added storage-related offer operations. > > > Diffs > ----- > > include/mesos/mesos.proto 86936cf9ad9406fa4c3358ccb3c58e2f3259d65f > include/mesos/v1/mesos.proto 20d9ecff68465c6517a5a239a4bd0f42f82d0cc6 > src/common/protobuf_utils.cpp 3ae68e93a985a4cfe23be9c9bd8f92e418102a39 > src/common/resources.cpp 8d4388935ada6be60448e6f6a88db0e5fc4ad4a1 > src/common/resources_utils.cpp 821bd0967d55f7fbcb57a4efae5fc390af53ca79 > src/master/master.cpp 183f53070848853b50bfb02bcd6b458ac0b2f685 > src/v1/resources.cpp 508f3f85c8388a41f57f964b0f6df3b4708d3442 > > > Diff: https://reviews.apache.org/r/58021/diff/6/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
