> On 八月 23, 2017, 12:29 a.m., Greg Mann wrote: > > src/tests/api_tests.cpp > > Lines 2214 (patched) > > <https://reviews.apache.org/r/61189/diff/5/?file=1800370#file1800370line2214> > > > > Since you don't modify these flags at all, you can get rid of this. If > > you start the master without a flags parameter, it will use the flags > > produced by `CreateMasterFlags()` by default.
This masterFlags because we are using the "masterFlags.allocation_interval" in later section. > On 八月 23, 2017, 12:29 a.m., Greg Mann wrote: > > src/tests/api_tests.cpp > > Lines 2222 (patched) > > <https://reviews.apache.org/r/61189/diff/5/?file=1800370#file1800370line2222> > > > > Can you move this down where you register the `connected` expectation > > on the scheduler? I don't quite understand it, this is pretty close to the connected expectation, why we need to move it? - Quinn ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61189/#review183548 ----------------------------------------------------------- On 八月 19, 2017, 3:33 a.m., Quinn Leng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61189/ > ----------------------------------------------------------- > > (Updated 八月 19, 2017, 3:33 a.m.) > > > Review request for mesos, Anand Mazumdar, Alexander Rojas, and Greg Mann. > > > Bugs: MESOS-7785 > https://issues.apache.org/jira/browse/MESOS-7785 > > > Repository: mesos > > > Description > ------- > > Added authorization filtering for the V1 operator events on the > master, the subscriber should only receive events that are > authorized based on their principal and ACLs. Since the authorizer > is called for every event emitted on the stream, the change of > authorization rule will affect events that the subscribers can > receive. > > > Diffs > ----- > > src/master/http.cpp b09a9d0ab5fab179d0e400932dce7d3ca958d7a8 > src/master/master.hpp d9cfc42646c874661e4ec79322126d93a2caf604 > src/master/master.cpp 7f38a5e21884546d4b4c866ca5918db779af8f99 > src/tests/api_tests.cpp 34480ea6818c904c64cb678562866f0b43dae0d6 > > > Diff: https://reviews.apache.org/r/61189/diff/5/ > > > Testing > ------- > > make check > GLOG_v=2 ./bin/mesos-tests.sh > --gtest_filter="ContentType/MasterAPITest.EventsAuthorizationFiltering*" > --verbose --gtest_repeat=100 --gtest_break_on_failure > > > Thanks, > > Quinn Leng > >
