----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60890/#review184044 -----------------------------------------------------------
include/mesos/agent/agent.proto Line 62 (original), 62 (patched) <https://reviews.apache.org/r/60890/#comment260048> curious, why the British spelling "favour" instead of "favor"? include/mesos/agent/agent.proto Line 184 (original), 248 (patched) <https://reviews.apache.org/r/60890/#comment260049> should these `xxxNestedContainer` optional fields be deprecated as well? include/mesos/agent/agent.proto Line 354 (original), 427 (patched) <https://reviews.apache.org/r/60890/#comment260050> deprecated? - James DeFelice On Aug. 29, 2017, 12:26 a.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60890/ > ----------------------------------------------------------- > > (Updated Aug. 29, 2017, 12:26 a.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-7305 > https://issues.apache.org/jira/browse/MESOS-7305 > > > Repository: mesos > > > Description > ------- > > Launching a standalone container is very similar to launching a > nested container, except that the caller must specify some Resources. > As such, this patch deprecates some nested container APIs > and replaces them with more generically named APIs. > > This applies to the Launch, Wait, and Kill (nested) container APIs. > > > Diffs > ----- > > include/mesos/agent/agent.proto 7c8c8a7d8298e91e4e002327b3b27d4c74b5cbae > include/mesos/v1/agent/agent.proto 3e199124b23fa027232790d99370fe2f33660096 > > > Diff: https://reviews.apache.org/r/60890/diff/2/ > > > Testing > ------- > > make > > See later patches in chain. > > > Thanks, > > Joseph Wu > >
