> On Aug. 29, 2017, 11:55 a.m., Alexander Rojas wrote: > > src/tests/slave_authorization_tests.cpp > > Lines 104-105 (original), 104-105 (patched) > > <https://reviews.apache.org/r/61666/diff/3/?file=1806144#file1806144line104> > > > > Remove this, it is not relevant anymore.
I've updated the checks. So, this comment is relevant again. > On Aug. 29, 2017, 11:55 a.m., Alexander Rojas wrote: > > src/tests/slave_authorization_tests.cpp > > Lines 106-109 (patched) > > <https://reviews.apache.org/r/61666/diff/3/?file=1806144#file1806144line106> > > > > Mention that two frameworks are launched with one task on each. Done. > On Aug. 29, 2017, 11:55 a.m., Alexander Rojas wrote: > > src/tests/slave_authorization_tests.cpp > > Line 168 (original), 197 (patched) > > <https://reviews.apache.org/r/61666/diff/3/?file=1806144#file1806144line197> > > > > I'm wondering if instead of _framework1_ and _framework2_, we can name > > it _frameworkSuperhero_ and _frameworkMuggle_. It will make everything > > easier to read. > > > > Same for executors and tasks. Fixed. > On Aug. 29, 2017, 11:55 a.m., Alexander Rojas wrote: > > src/tests/slave_authorization_tests.cpp > > Line 212 (original), 277 (patched) > > <https://reviews.apache.org/r/61666/diff/3/?file=1806144#file1806144line279> > > > > Perhaps a comment indicating that this task will run on executor1 of > > framework1 Done. - Andrei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61666/#review184042 ----------------------------------------------------------- On Aug. 15, 2017, 5:59 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61666/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2017, 5:59 p.m.) > > > Review request for mesos, Alexander Rojas and Greg Mann. > > > Bugs: MESOS-7892 > https://issues.apache.org/jira/browse/MESOS-7892 > > > Repository: mesos > > > Description > ------- > > This patch extends `SlaveAuthorizerTest.FilterStateEndpoint` test to > check that agent's `/state` endpoint shows resource reservations and > allocations based on the 'VIEW_ROLE' permissions of the principal > doing the request. > > > Diffs > ----- > > src/tests/slave_authorization_tests.cpp > 536a8efda0cc1ba08285c379b01af6ec64a82117 > > > Diff: https://reviews.apache.org/r/61666/diff/4/ > > > Testing > ------- > > make check (mac os x, fedora 25) > > > Thanks, > > Andrei Budnik > >
