----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61666/#review184486 -----------------------------------------------------------
Fix it, then Ship it! Be consistent in the description, you use sometimes ` and sometimes ' src/tests/slave_authorization_tests.cpp Lines 185-186 (original), 236-237 (patched) <https://reviews.apache.org/r/61666/#comment260639> g/sched1/schedSuperhero/ g/driver1/driverSuperhero/ src/tests/slave_authorization_tests.cpp Lines 280-281 (patched) <https://reviews.apache.org/r/61666/#comment260640> g/sched2/schedMuggle/ g/driver2/driverMuggle/ - Alexander Rojas On Aug. 15, 2017, 7:59 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61666/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2017, 7:59 p.m.) > > > Review request for mesos, Alexander Rojas and Greg Mann. > > > Bugs: MESOS-7892 > https://issues.apache.org/jira/browse/MESOS-7892 > > > Repository: mesos > > > Description > ------- > > This patch extends `SlaveAuthorizerTest.FilterStateEndpoint` test to > check that agent's `/state` endpoint shows resource reservations and > allocations based on the 'VIEW_ROLE' permissions of the principal > doing the request. > > > Diffs > ----- > > src/tests/slave_authorization_tests.cpp > 536a8efda0cc1ba08285c379b01af6ec64a82117 > > > Diff: https://reviews.apache.org/r/61666/diff/4/ > > > Testing > ------- > > make check (mac os x, fedora 25) > > > Thanks, > > Andrei Budnik > >
