----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61920/#review184182 -----------------------------------------------------------
Fix it, then Ship it! LGTM, just a couple small nits below. src/tests/containerizer/environment_secret_isolator_tests.cpp Lines 170 (patched) <https://reviews.apache.org/r/61920/#comment260257> Is this needed? src/tests/containerizer/environment_secret_isolator_tests.cpp Lines 226 (patched) <https://reviews.apache.org/r/61920/#comment260259> s/statusRunning.get().state()/statusRunning->state()/ src/tests/containerizer/environment_secret_isolator_tests.cpp Lines 228 (patched) <https://reviews.apache.org/r/61920/#comment260260> s/statusFinished.get().state()/statusFinished->state()/ - Greg Mann On Aug. 25, 2017, 11:45 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61920/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2017, 11:45 p.m.) > > > Review request for mesos and Greg Mann. > > > Bugs: MESOS-7916 > https://issues.apache.org/jira/browse/MESOS-7916 > > > Repository: mesos > > > Description > ------- > > This test checks that environment secrets are properly resolved and > exposed to tasks started by the DefaultExecutor. > > > Diffs > ----- > > src/tests/containerizer/environment_secret_isolator_tests.cpp > 2ba156f081c3a7c47d746f4750dbd74771b341c1 > > > Diff: https://reviews.apache.org/r/61920/diff/1/ > > > Testing > ------- > > The test succeeds on GNU/Linux. > > > Thanks, > > Gastón Kleiman > >
