> On Aug. 30, 2017, 7:33 p.m., Greg Mann wrote: > > src/tests/containerizer/environment_secret_isolator_tests.cpp > > Lines 170 (patched) > > <https://reviews.apache.org/r/61920/diff/1/?file=1804173#file1804173line170> > > > > Is this needed?
This avoids getting gtest warnings if for some reason the nested containers take long to execute and the driver gets another offer. - Gastón ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61920/#review184182 ----------------------------------------------------------- On Aug. 30, 2017, 8:37 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61920/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2017, 8:37 p.m.) > > > Review request for mesos and Greg Mann. > > > Bugs: MESOS-7916 > https://issues.apache.org/jira/browse/MESOS-7916 > > > Repository: mesos > > > Description > ------- > > This test checks that environment secrets are properly resolved and > exposed to tasks started by the DefaultExecutor. > > > Diffs > ----- > > src/tests/containerizer/environment_secret_isolator_tests.cpp > 2ba156f081c3a7c47d746f4750dbd74771b341c1 > > > Diff: https://reviews.apache.org/r/61920/diff/2/ > > > Testing > ------- > > The test succeeds on GNU/Linux. > > > Thanks, > > Gastón Kleiman > >
