----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61213/#review184482 -----------------------------------------------------------
Patch looks great! Reviews applied: [60088, 61212, 61213] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Sept. 3, 2017, 10:43 a.m., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61213/ > ----------------------------------------------------------- > > (Updated Sept. 3, 2017, 10:43 a.m.) > > > Review request for mesos and Kevin Klues. > > > Bugs: MESOS-7840 > https://issues.apache.org/jira/browse/MESOS-7840 > > > Repository: mesos > > > Description > ------- > > This command displays the active tasks in a cluster > by reaching the tasks endpoint of a master. It also > works when Mesos uses runs in High-Availability Mode. > > > Diffs > ----- > > src/python/cli_new/bin/settings.py d42df04b0ff42bb6f466842e59223cd90a74d5c0 > src/python/cli_new/lib/cli/plugins/task/__init__.py PRE-CREATION > src/python/cli_new/lib/cli/plugins/task/main.py PRE-CREATION > src/python/cli_new/lib/cli/tests/__init__.py > 0daf28869e107263c51653ace39e3b1826871048 > src/python/cli_new/lib/cli/tests/task.py PRE-CREATION > src/python/cli_new/tests/main.py 3e4d2e449a6485206700b4a490d325a393d31f90 > > > Diff: https://reviews.apache.org/r/61213/diff/2/ > > > Testing > ------- > > To test with one master: > ``` > $ ./bootstrap > $ source activate > $ mesos-cli-tests > ``` > > To test the command in High-Availability Mode I have: > 1. Started ZooKeeper. > 2. Started two masters using the flags `--zk` and `--quorum`. > 3. Started one agent. > 4. Launched one task using `./mesos-execute > --master='zk://127.0.0.1:2181/mesos' --name='test' --command='sleep 3600'`. > 5. Checked that the output of 'mesos task list' was correct. > > I also checked that the Python linter was still working. > > > Thanks, > > Armand Grillet > >
