----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60593/#review184663 -----------------------------------------------------------
src/tests/containerizer/ports_isolator_tests.cpp Lines 784 (patched) <https://reviews.apache.org/r/60593/#comment260856> I think we need to enable the `network/ports` isolator when the agent is restarted (just like what you did for `NetworkPortsIsolatorTest.ROOT_NC_RecoverNestedGoodTask`) rather than when the agent is started for the first time. - Qian Zhang On Aug. 31, 2017, 8:08 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60593/ > ----------------------------------------------------------- > > (Updated Aug. 31, 2017, 8:08 a.m.) > > > Review request for mesos, Qian Zhang and Jiang Yan Xu. > > > Bugs: MESOS-7675 > https://issues.apache.org/jira/browse/MESOS-7675 > > > Repository: mesos > > > Description > ------- > > Added a test for the `network/ports` isolator recovery by starting > a task that is listening on a rogue port. We only configure the > isolator when we restart the agent to simulate the case where a > task only starts to misbehave after an agent recovery. > > > Diffs > ----- > > src/tests/containerizer/ports_isolator_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/60593/diff/14/ > > > Testing > ------- > > make check (Fedora 26) > > > Thanks, > > James Peach > >
