> On Sept. 6, 2017, 12:19 p.m., Qian Zhang wrote: > > src/tests/containerizer/ports_isolator_tests.cpp > > Lines 741 (patched) > > <https://reviews.apache.org/r/60593/diff/14/?file=1808286#file1808286line741> > > > > Why do we need to explicitly set this flag to such a large number?
I ended up removing this altogether. It is not necessary and setting it too high makes recovery tests flaky. - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60593/#review184657 ----------------------------------------------------------- On Aug. 31, 2017, 12:08 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60593/ > ----------------------------------------------------------- > > (Updated Aug. 31, 2017, 12:08 a.m.) > > > Review request for mesos, Qian Zhang and Jiang Yan Xu. > > > Bugs: MESOS-7675 > https://issues.apache.org/jira/browse/MESOS-7675 > > > Repository: mesos > > > Description > ------- > > Added a test for the `network/ports` isolator recovery by starting > a task that is listening on a rogue port. We only configure the > isolator when we restart the agent to simulate the case where a > task only starts to misbehave after an agent recovery. > > > Diffs > ----- > > src/tests/containerizer/ports_isolator_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/60593/diff/14/ > > > Testing > ------- > > make check (Fedora 26) > > > Thanks, > > James Peach > >
