-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62106/
-----------------------------------------------------------
(Updated Sept. 8, 2017, 10:13 p.m.)
Review request for mesos, Andrew Schwartzmeyer, Jeff Coffler, and Joseph Wu.
Changes
-------
Addressed new comments
Bugs: MESOS-3384
https://issues.apache.org/jira/browse/MESOS-3384
Repository: mesos
Description
-------
Enabled CRAM MD5 Authentication on Windows and associated tests.
Diffs (updated)
-----
cmake/CompilationConfigure.cmake 4cb8dddf93694722af2377c4a55a195260c8a0cb
docs/configuration-cmake.md d2eb571c9458c7fade415e8077c676dd34e63242
docs/windows.md b47ba5a0db3d41d6f4bb002283b40622a2bb3e0f
src/CMakeLists.txt 1a828c4351ded36f51ccbbe67147da2f50b9cdb1
src/Makefile.am a4f2ee008eba263fe52c4e58c305e3fb9ba42f6b
src/authentication/cram_md5/authenticatee.cpp
7b3f767e29163de489018081089e67a6f22971c5
src/authentication/cram_md5/authenticator.cpp
2a12bb3f4aec79056ec6c82a8c896ee3af15bb4c
src/authentication/cram_md5/auxprop.hpp
dedcbe514283dd86a924d92ccdd17173ebe878cb
src/master/master.cpp 14d94cfa0e96881f77dd6e0c3449fdc0613e36ce
src/sched/sched.cpp ef73c1dccfd736b79f40a057951f022df7f60644
src/slave/slave.cpp 6d1516a5d5b5db684f79385e60d892ff75fd00fd
src/tests/CMakeLists.txt def233d13f627f58362fdc61ac3e9c104d65fe7e
src/tests/authentication_tests.cpp b04be76d23788fbde337eaf85716ec7436ade691
src/tests/mesos.cpp fc7f8cb09e223000ea160aa4ab83a003cf4af2fb
support/windows-build.bat 100013ed68ecc2f431c20a3f081f8aa6eca961ef
Diff: https://reviews.apache.org/r/62106/diff/4/
Changes: https://reviews.apache.org/r/62106/diff/3-4/
Testing
-------
Ran the automake build and the cmake build on Linux, as well as the cmake build
on Windows, with no errors. Ran tests on both platforms as well. Note: The
mesos-3rdparty pull request which contains the cyrus-sasl package needs to be
merged to master first before these patches will work. (Or, have the cyrus-sasl
tarball available in a local 3rdparty directory, configured with mesos)
Thanks,
John Kordich
