----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62106/#review185748 -----------------------------------------------------------
Ship it! This is awesome! ``` [----------] 21 tests from AuthenticationTest [ RUN ] AuthenticationTest.UnauthenticatedFramework [ OK ] AuthenticationTest.UnauthenticatedFramework (114 ms) [ RUN ] AuthenticationTest.UnauthenticatedSlave [ OK ] AuthenticationTest.UnauthenticatedSlave (98 ms) [ RUN ] AuthenticationTest.DisableFrameworkAuthentication [ OK ] AuthenticationTest.DisableFrameworkAuthentication (47 ms) [ RUN ] AuthenticationTest.DisableSlaveAuthentication [ OK ] AuthenticationTest.DisableSlaveAuthentication (103 ms) [ RUN ] AuthenticationTest.MismatchedFrameworkInfoPrincipal [ OK ] AuthenticationTest.MismatchedFrameworkInfoPrincipal (49 ms) [ RUN ] AuthenticationTest.DisabledFrameworkAuthenticationPrincipalMismatch [ OK ] AuthenticationTest.DisabledFrameworkAuthenticationPrincipalMismatch (47 ms) [ RUN ] AuthenticationTest.UnspecifiedFrameworkInfoPrincipal [ OK ] AuthenticationTest.UnspecifiedFrameworkInfoPrincipal (49 ms) [ RUN ] AuthenticationTest.AuthenticatedFramework [ OK ] AuthenticationTest.AuthenticatedFramework (50 ms) [ RUN ] AuthenticationTest.AuthenticatedSlave [ OK ] AuthenticationTest.AuthenticatedSlave (111 ms) [ RUN ] AuthenticationTest.RetryFrameworkAuthentication [ OK ] AuthenticationTest.RetryFrameworkAuthentication (1170 ms) [ RUN ] AuthenticationTest.RetrySlaveAuthentication [ OK ] AuthenticationTest.RetrySlaveAuthentication (709 ms) [ RUN ] AuthenticationTest.DropIntermediateSASLMessage [ OK ] AuthenticationTest.DropIntermediateSASLMessage (371 ms) [ RUN ] AuthenticationTest.DropIntermediateSASLMessageForSlave [ OK ] AuthenticationTest.DropIntermediateSASLMessageForSlave (157 ms) [ RUN ] AuthenticationTest.DropFinalSASLMessage [ OK ] AuthenticationTest.DropFinalSASLMessage (1319 ms) [ RUN ] AuthenticationTest.DropFinalSASLMessageForSlave [ OK ] AuthenticationTest.DropFinalSASLMessageForSlave (1536 ms) [ RUN ] AuthenticationTest.MasterFailover [ OK ] AuthenticationTest.MasterFailover (2121 ms) [ RUN ] AuthenticationTest.MasterFailoverDuringSlaveAuthentication [ OK ] AuthenticationTest.MasterFailoverDuringSlaveAuthentication (514 ms) [ RUN ] AuthenticationTest.LeaderElection [ OK ] AuthenticationTest.LeaderElection (1737 ms) [ RUN ] AuthenticationTest.LeaderElectionDuringSlaveAuthentication [ OK ] AuthenticationTest.LeaderElectionDuringSlaveAuthentication (1462 ms) [ RUN ] AuthenticationTest.SchedulerFailover [ OK ] AuthenticationTest.SchedulerFailover (82 ms) [ RUN ] AuthenticationTest.RejectedSchedulerFailover [ OK ] AuthenticationTest.RejectedSchedulerFailover (66 ms) [----------] 21 tests from AuthenticationTest (11970 ms total) ``` - Andrew Schwartzmeyer On Sept. 19, 2017, 9:57 a.m., John Kordich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62106/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2017, 9:57 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Jeff Coffler, Greg Mann, Jie > Yu, Joseph Wu, and Till Toenshoff. > > > Bugs: MESOS-3384 > https://issues.apache.org/jira/browse/MESOS-3384 > > > Repository: mesos > > > Description > ------- > > Enabled CRAM MD5 Authentication on Windows and associated tests. > > > Diffs > ----- > > cmake/CompilationConfigure.cmake 4cb8dddf93694722af2377c4a55a195260c8a0cb > docs/configuration-cmake.md d2eb571c9458c7fade415e8077c676dd34e63242 > docs/windows.md b47ba5a0db3d41d6f4bb002283b40622a2bb3e0f > src/CMakeLists.txt 1a828c4351ded36f51ccbbe67147da2f50b9cdb1 > src/Makefile.am 93ed2bf55447e3e470d9bea8a0b61ce78aad1900 > src/master/master.cpp 6d84a26bff970b842b58dfb69dbf232ba5c16a20 > src/sched/sched.cpp 09f255e4affe79b7482ba62efcfa5cf78327735e > src/slave/slave.cpp 391a0d6db29660d5eb38eab367a2ccf9d453e69d > src/tests/CMakeLists.txt def233d13f627f58362fdc61ac3e9c104d65fe7e > src/tests/authentication_tests.cpp b04be76d23788fbde337eaf85716ec7436ade691 > src/tests/mesos.cpp fc7f8cb09e223000ea160aa4ab83a003cf4af2fb > support/windows-build.bat 100013ed68ecc2f431c20a3f081f8aa6eca961ef > > > Diff: https://reviews.apache.org/r/62106/diff/5/ > > > Testing > ------- > > Ran the automake build and the cmake build on Linux, as well as the cmake > build on Windows, with no errors. Ran tests on both platforms as well. > Note: The mesos-3rdparty pull request which contains the cyrus-sasl package > needs to be merged to master first before these patches will work. (Or, have > the cyrus-sasl tarball available in a local 3rdparty directory, configured > with mesos) > > > Thanks, > > John Kordich > >
