----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62158/#review185571 -----------------------------------------------------------
Fix it, then Ship it! src/master/master.cpp Lines 6779-6781 (original), 6787-6789 (patched) <https://reviews.apache.org/r/62158/#comment261885> Why change the formatting. I think the old style is better. src/master/master.cpp Lines 6797-6798 (patched) <https://reviews.apache.org/r/62158/#comment261887> Ditto on logging style. Please be consistent with others in this file. - Jie Yu On Sept. 15, 2017, 1:15 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62158/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2017, 1:15 p.m.) > > > Review request for mesos, Jie Yu and Jan Schlicht. > > > Bugs: MESOS-7757 > https://issues.apache.org/jira/browse/MESOS-7757 > > > Repository: mesos > > > Description > ------- > > When an agent changes its resources, the master should rescind any > offers affected by the change. We already performed the rescind for > updates to the agent's oversubscribed resources; this patch adds offer > rescinding when an update an agent's total resources is processed. > > While for updates to an agent's oversubscribed resources we currently > only rescind offers containing revocable resources to e.g., reduce > offer churn, we for updates to the total we here currently rescind all > offers for resources on the agent. > > > Diffs > ----- > > src/master/master.cpp 6d84a26bff970b842b58dfb69dbf232ba5c16a20 > > > Diff: https://reviews.apache.org/r/62158/diff/2/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
