----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62158/#review186983 -----------------------------------------------------------
Fix it, then Ship it! src/master/master.cpp Line 6841 (original), 6841 (patched) <https://reviews.apache.org/r/62158/#comment263936> For consistency, we still use 'Slave' for variable names (in this file). Let's use newSlaveTotalResources here. - Jie Yu On Oct. 2, 2017, 4:53 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62158/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2017, 4:53 p.m.) > > > Review request for mesos, Jie Yu and Jan Schlicht. > > > Bugs: MESOS-7757 > https://issues.apache.org/jira/browse/MESOS-7757 > > > Repository: mesos > > > Description > ------- > > When an agent changes its resources, the master should rescind any > offers affected by the change. We already performed the rescind for > updates to the agent's oversubscribed resources; this patch adds offer > rescinding when an update an agent's total resources is processed. > > While for updates to an agent's oversubscribed resources we currently > only rescind offers containing revocable resources to e.g., reduce > offer churn, for updates to the total we here currently rescind all > offers for resources on the agent. > > As an optimization, this patch adds logic to ignore redundant updates > to agent resources. > > > Diffs > ----- > > src/master/master.cpp b40621ee3870b1968ab1b05dd0f41a489f4db00e > > > Diff: https://reviews.apache.org/r/62158/diff/7/ > > > Testing > ------- > > Tested on a number of platforms on internal CI. > > > Thanks, > > Benjamin Bannier > >
