----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62285/#review186083 -----------------------------------------------------------
src/log/leveldb.cpp Lines 247 (patched) <https://reviews.apache.org/r/62285/#comment262505> I would combine this condition with the condition in `else if` above. src/log/leveldb.cpp Lines 364-366 (patched) <https://reviews.apache.org/r/62285/#comment262506> Can you explain this a bit more. When I see the code in `restore` above, I thought the invariant you want to maintain is: there is no tombstone entry in the replica's [begin,end]. Why the recovery code needs to see this position? src/log/replica.cpp Lines 735-736 (patched) <https://reviews.apache.org/r/62285/#comment262507> Ditto on combining considtions into a single `else if` - Jie Yu On Sept. 13, 2017, 4:40 p.m., Ilya Pronin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62285/ > ----------------------------------------------------------- > > (Updated Sept. 13, 2017, 4:40 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-7973 > https://issues.apache.org/jira/browse/MESOS-7973 > > > Repository: mesos > > > Description > ------- > > NOP action is used as a filler for holes in the "fill" procedure and as > the action in a response to a promise request for a truncated position. > The tombstone flag is introduced so that replicas are able to > distinguish the truncated action from a real NOP. > > > Diffs > ----- > > src/log/leveldb.cpp 5310a123b0fb25f240429722b676fe46174cb2ce > src/log/replica.cpp 39f2879b2e37c1ca9a9f987ce0a3b83e8dbc9b43 > src/messages/log.proto ca740bd011147f8f48cc5dfcacefa5fdbd95ccd0 > src/tests/log_tests.cpp f9f9400c901152779ae0ebfe74cf8f7aac1d3396 > > > Diff: https://reviews.apache.org/r/62285/diff/1/ > > > Testing > ------- > > Added a test that verifies that a replica correctly handles the tombstone > NOP. Ran `make check`. > > > Thanks, > > Ilya Pronin > >
