----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61212/#review186254 -----------------------------------------------------------
src/python/cli_new/lib/cli/util.py Lines 162 (patched) <https://reviews.apache.org/r/61212/#comment262738> Can we change this comment to make the usage of 'basestring' here more clear (how it is the base class for both unicode and string and depending on how this field is passed in it could be either of these). src/python/cli_new/lib/cli/util.py Lines 169 (patched) <https://reviews.apache.org/r/61212/#comment262739> s/respect/match/ src/python/cli_new/lib/cli/util.py Lines 188 (patched) <https://reviews.apache.org/r/61212/#comment262740> Let's break this out into its own commit. - Kevin Klues On Sept. 26, 2017, 1:53 p.m., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61212/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2017, 1:53 p.m.) > > > Review request for mesos and Kevin Klues. > > > Bugs: MESOS-7840 > https://issues.apache.org/jira/browse/MESOS-7840 > > > Repository: mesos > > > Description > ------- > > This will be used by future plugins. > > > Diffs > ----- > > src/python/cli_new/lib/cli/util.py 7371f83543ed527bea8dbf2fe4e20d92ef8e4492 > > > Diff: https://reviews.apache.org/r/61212/diff/6/ > > > Testing > ------- > > Tested manually, PEP8 and Pylint used to make sure that the code style is > correct. > > > Thanks, > > Armand Grillet > >
