----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62592/#review186476 -----------------------------------------------------------
src/authentication/http/basic_authenticatee.cpp Lines 41-42 (patched) <https://reviews.apache.org/r/62592/#comment263038> I think we usually put the `{}` on the same line as the initialization list? src/authentication/http/basic_authenticatee.cpp Lines 48 (patched) <https://reviews.apache.org/r/62592/#comment263043> We use trailing underscores for similar variables within a scope, but the style guide explicitly suggests moving away from this pattern: "Some trailing underscores are used to distinguish between similar variables in the same scope (think prime symbols), but this should be avoided as much as possible, including removing existing instances in the code base." Maybe use a new variable name, something like `decoratedRequest` maybe? src/authentication/http/basic_authenticatee.cpp Lines 75-76 (patched) <https://reviews.apache.org/r/62592/#comment263048> Hmm wouldn't we usually indent two spaces after the linebreak here? - Greg Mann On Sept. 26, 2017, 10:54 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62592/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2017, 10:54 p.m.) > > > Review request for mesos, Armand Grillet, Benjamin Bannier, Greg Mann, and > Kapil Arya. > > > Bugs: MESOS-8017 > https://issues.apache.org/jira/browse/MESOS-8017 > > > Repository: mesos > > > Description > ------- > > Added basic HTTP authenticatee implementation. > > > Diffs > ----- > > src/CMakeLists.txt 1a828c4351ded36f51ccbbe67147da2f50b9cdb1 > src/Makefile.am 93ed2bf55447e3e470d9bea8a0b61ce78aad1900 > src/authentication/http/basic_authenticatee.hpp PRE-CREATION > src/authentication/http/basic_authenticatee.cpp PRE-CREATION > src/common/http.hpp 0e6b1c59860e75c04e2e3be2520ed2b39c84ac90 > > > Diff: https://reviews.apache.org/r/62592/diff/1/ > > > Testing > ------- > > Integration test in external project. Further tests upcoming. > > > Thanks, > > Till Toenshoff > >
