> On Sept. 27, 2017, 9:21 p.m., Greg Mann wrote: > > src/authentication/http/basic_authenticatee.cpp > > Lines 75-76 (patched) > > <https://reviews.apache.org/r/62592/diff/1/?file=1836080#file1836080line75> > > > > Hmm wouldn't we usually indent two spaces after the linebreak here? > > Till Toenshoff wrote: > Again clangformat things otherwise - unsure actually bout these cases of > a return type already needing a linebreak.
https://google.github.io/styleguide/cppguide.html#Function_Declarations_and_Definitions > If you break after the return type of a function declaration or definition, > do not indent. - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62592/#review186476 ----------------------------------------------------------- On Sept. 26, 2017, 10:54 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62592/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2017, 10:54 p.m.) > > > Review request for mesos, Armand Grillet, Benjamin Bannier, Greg Mann, and > Kapil Arya. > > > Bugs: MESOS-8017 > https://issues.apache.org/jira/browse/MESOS-8017 > > > Repository: mesos > > > Description > ------- > > Added basic HTTP authenticatee implementation. > > > Diffs > ----- > > src/CMakeLists.txt 1a828c4351ded36f51ccbbe67147da2f50b9cdb1 > src/Makefile.am 93ed2bf55447e3e470d9bea8a0b61ce78aad1900 > src/authentication/http/basic_authenticatee.hpp PRE-CREATION > src/authentication/http/basic_authenticatee.cpp PRE-CREATION > src/common/http.hpp 0e6b1c59860e75c04e2e3be2520ed2b39c84ac90 > > > Diff: https://reviews.apache.org/r/62592/diff/1/ > > > Testing > ------- > > Integration test in external project. Further tests upcoming. > > > Thanks, > > Till Toenshoff > >
