----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62212/#review187711 -----------------------------------------------------------
src/launcher/default_executor.cpp Lines 489-490 (patched) <https://reviews.apache.org/r/62212/#comment264760> You don't need to explicitly call out `None()`. As a bonus, you can fit it in one line : ) src/launcher/default_executor.cpp Lines 528-529 (original), 555-556 (patched) <https://reviews.apache.org/r/62212/#comment264758> Please check the internal invariant: `CHECK(containers.contains(taskId));` - Alexander Rukletsov On Oct. 11, 2017, 10:28 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62212/ > ----------------------------------------------------------- > > (Updated Oct. 11, 2017, 10:28 p.m.) > > > Review request for mesos, Andrei Budnik and Alexander Rukletsov. > > > Bugs: MESOS-7941 > https://issues.apache.org/jira/browse/MESOS-7941 > > > Repository: mesos > > > Description > ------- > > This gives schedulers more information about a tasks status, > in particular it gives a better estimate of a tasks start time > and helps differentiating between tasks stuck in TASK_STAGING > and tasks stuck in TASK_STARTING. > > > Diffs > ----- > > docs/high-availability-framework-guide.md > 73743aba31f9d0ca827d318e2ecb4752a91b1be0 > src/docker/executor.cpp 3b0767ffbbe9982639d0b87fbb0573accdd48559 > src/launcher/default_executor.cpp 136c000917b2c4fdaf68fd460764c3a15fdf3bf0 > src/launcher/executor.cpp 0131577d5b9018e7094815f1377b2ee59a4493d4 > > > Diff: https://reviews.apache.org/r/62212/diff/4/ > > > Testing > ------- > > * `make check` > * Installed in local DC/OS cluster and successfully completed the tweeter > tutorial > * Installed in local DC/OS cluster and successfully ran a periodic sleep task > using chronos. > > > Thanks, > > Benno Evers > >
