----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60622/#review188011 -----------------------------------------------------------
3rdparty/stout/include/stout/path.hpp Lines 28-46 (patched) <https://reviews.apache.org/r/60622/#comment265081> This should be replaced with `path::from_uri` which validates the `file://` portion, and fixes the slashes on Windows, as mentioned in the other review. 3rdparty/stout/include/stout/uri.hpp Lines 24-27 (patched) <https://reviews.apache.org/r/60622/#comment265090> After looking at the other reviews, the reason for using this publicly appears dubious. It's bandaging the incorrect construction of URLs that used `path::join` to join their components, a pattern that should be avoided in cross-platform code. - Andrew Schwartzmeyer On Oct. 11, 2017, 4:31 p.m., Jeff Coffler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60622/ > ----------------------------------------------------------- > > (Updated Oct. 11, 2017, 4:31 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and > Li Li. > > > Bugs: MESOS-6705 > https://issues.apache.org/jira/browse/MESOS-6705 > > > Repository: mesos > > > Description > ------- > > Added new stout function: path::normalize (normalize a filename), > along with uri::from_path (generate URI from file path). > > > Diffs > ----- > > 3rdparty/stout/Makefile.am 4386017acd6ca465be3f735460c11d50b440ccc5 > 3rdparty/stout/include/Makefile.am bdd3e9908ebfc682458a3babc34cbee36ad3f751 > 3rdparty/stout/include/stout/path.hpp > 6ee3a44cd6a878fe383aa68df40b82857b93d0b4 > 3rdparty/stout/include/stout/uri.hpp PRE-CREATION > 3rdparty/stout/tests/CMakeLists.txt > 6e5773f1e03671de7ac007caf49edd0f1cd7aedd > 3rdparty/stout/tests/path_tests.cpp > f8c14d5aefe0b49adb778da784143a328c96183d > 3rdparty/stout/tests/uri_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/60622/diff/3/ > > > Testing > ------- > > See upstream > > > Thanks, > > Jeff Coffler > >
