----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60622/#review188414 -----------------------------------------------------------
3rdparty/stout/include/stout/path.hpp Lines 45-52 (patched) <https://reviews.apache.org/r/60622/#comment265415> The `startsWith` is unecessary. This can be replaced with one line: ``` std::string path = strings::remove(path, "file://", strings::PREFIX);` ``` Since `strings::remove` is idempotent. 3rdparty/stout/include/stout/path.hpp Lines 47 (patched) <https://reviews.apache.org/r/60622/#comment265414> nit: comments must end with `.` 3rdparty/stout/include/stout/path.hpp Lines 48 (patched) <https://reviews.apache.org/r/60622/#comment265411> nit: whitespace 3rdparty/stout/include/stout/path.hpp Lines 49-50 (patched) <https://reviews.apache.org/r/60622/#comment265413> nit: open brace should be on line with `if` 3rdparty/stout/include/stout/uri.hpp Lines 24 (patched) <https://reviews.apache.org/r/60622/#comment265416> nit: comment must end with a `.`, and this should perhaps mention why we replace `` with `/` on Windows. - Andrew Schwartzmeyer On Oct. 16, 2017, 6:17 p.m., Jeff Coffler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60622/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2017, 6:17 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and > Li Li. > > > Bugs: MESOS-6705 > https://issues.apache.org/jira/browse/MESOS-6705 > > > Repository: mesos > > > Description > ------- > > Added new stout function: path::from_uri, which converts to a filepath > from a URI. > > Also added uri::from_path, which generates a URI from a file path. > > > Diffs > ----- > > 3rdparty/stout/Makefile.am 4386017acd6ca465be3f735460c11d50b440ccc5 > 3rdparty/stout/include/Makefile.am bdd3e9908ebfc682458a3babc34cbee36ad3f751 > 3rdparty/stout/include/stout/path.hpp > 6ee3a44cd6a878fe383aa68df40b82857b93d0b4 > 3rdparty/stout/include/stout/uri.hpp PRE-CREATION > 3rdparty/stout/tests/CMakeLists.txt > 6e5773f1e03671de7ac007caf49edd0f1cd7aedd > 3rdparty/stout/tests/path_tests.cpp > f8c14d5aefe0b49adb778da784143a328c96183d > 3rdparty/stout/tests/uri_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/60622/diff/4/ > > > Testing > ------- > > See upstream > > > Thanks, > > Jeff Coffler > >
