----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62241/#review188053 -----------------------------------------------------------
Looks good, just a few minor things to clean up. src/tests/scheduler_http_api_tests.cpp Lines 674 (patched) <https://reviews.apache.org/r/62241/#comment265133> s/an/a src/tests/scheduler_http_api_tests.cpp Lines 712-716 (patched) <https://reviews.apache.org/r/62241/#comment265134> Do you care about a `HEARTBEAT` even for this test? src/tests/scheduler_http_api_tests.cpp Lines 737-747 (patched) <https://reviews.apache.org/r/62241/#comment265135> Kill this? We don't need this to test if the downgrade worked. - Anand Mazumdar On Sept. 12, 2017, 12:59 p.m., Ilya Pronin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62241/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2017, 12:59 p.m.) > > > Review request for mesos and Anand Mazumdar. > > > Bugs: MESOS-7867 > https://issues.apache.org/jira/browse/MESOS-7867 > > > Repository: mesos > > > Description > ------- > > This test verifies that we are able to upgrade from a PID based > framework to an HTTP framework and then downgrade back without > restarting the master. > > > Diffs > ----- > > src/tests/scheduler_http_api_tests.cpp > cc03be0d2110f08023bf0ce181da37658737bd7c > > > Diff: https://reviews.apache.org/r/62241/diff/1/ > > > Testing > ------- > > Ran `make check`. Verified that the test fails without the previous patch. > > > Thanks, > > Ilya Pronin > >
