----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/#review188116 -----------------------------------------------------------
include/mesos/v1/resource_provider/resource_provider.proto Lines 89-91 (original), 83-87 (patched) <https://reviews.apache.org/r/63001/#comment265164> It's important to include the result of certain operations, i.e., `converted_resources`. `converted_resources` provides the result of RP operations like `CREATE_VOLUME`. Also the `operation` (or at least its resources) need to be included to be able to rollback resources in case of a failure. src/messages/messages.proto Lines 643-648 (patched) <https://reviews.apache.org/r/63001/#comment265163> For certain operations like `CREATE_VOLUME` the resources that resulted from applying the operation have to be sent here as part of this operation. Otherwise the master won't be able to recover these resources and offer them to frameworks. Also the `operation` (or at least its resources) need to be included to be able to rollback resources in case of a failure. - Jan Schlicht On Oct. 15, 2017, 6:30 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63001/ > ----------------------------------------------------------- > > (Updated Oct. 15, 2017, 6:30 a.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Mahler, Gaston Kleiman, > Greg Mann, Jan Schlicht, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Updated protobuf definitions related to offer operations. > > > Diffs > ----- > > include/mesos/mesos.proto ba87339dbe341f4d16ceea74adc09647a3c07f32 > include/mesos/resource_provider/resource_provider.proto > f5a9073075327019fd133bd51265f695ef464845 > include/mesos/v1/mesos.proto a6d662fb26aa4f78ef20ffe6e013f7a45f7f8c21 > include/mesos/v1/resource_provider/resource_provider.proto > e5cbede5b6e57a8641fca1ebfee5454f292cc24c > src/messages/messages.proto 0a32b3457e9143a7d48670610ca3e56dd516136f > src/resource_provider/manager.cpp 31fcb789f5ab907511e868c374c49f7457a33ed3 > src/resource_provider/validation.cpp > d2927227f60ab0d4ae2481ad73a31ee444b48ee0 > src/tests/resource_provider_validation_tests.cpp > f182bff4670318e9de22c2915c5dbb423a74ad6c > > > Diff: https://reviews.apache.org/r/63001/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
