----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/#review188162 -----------------------------------------------------------
include/mesos/v1/mesos.proto Lines 2124 (patched) <https://reviews.apache.org/r/63001/#comment265208> s/informations/information/ src/messages/messages.proto Lines 637-638 (patched) <https://reviews.apache.org/r/63001/#comment265218> I think that this list should include pending operations, but should _not_ include terminal operations with unacknowledged updates. When the master receives an update, it needs to decide whether or not it should update the allocator. If the operation was pending when `UpdateSlaveMessage` was sent, then the master should update the allocator. If the operation was not pending but its update had not been acknowledged, then the result of that operation was already reflected in the last `UpdateSlaveMessage` from the agent, and the master should not update the allocator. If the agent includes only pending operations in this field, then the master will be able to make this distinction. src/messages/messages.proto Lines 643-648 (patched) <https://reviews.apache.org/r/63001/#comment265202> I think that we need to include the agent’s clock value in this message. When the master receives an operation status update, it must be able to determine whether that update was sent before or after the next UpdateSlaveMessage from the agent. To do this, it must inspect a clock value contained in each update. - Greg Mann On Oct. 16, 2017, 6:32 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63001/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2017, 6:32 p.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Mahler, Gaston Kleiman, > Greg Mann, Jan Schlicht, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Updated protobuf definitions related to offer operations. > > > Diffs > ----- > > include/mesos/mesos.proto ba87339dbe341f4d16ceea74adc09647a3c07f32 > include/mesos/resource_provider/resource_provider.proto > f5a9073075327019fd133bd51265f695ef464845 > include/mesos/v1/mesos.proto a6d662fb26aa4f78ef20ffe6e013f7a45f7f8c21 > include/mesos/v1/resource_provider/resource_provider.proto > e5cbede5b6e57a8641fca1ebfee5454f292cc24c > src/messages/messages.proto 0a32b3457e9143a7d48670610ca3e56dd516136f > src/resource_provider/manager.cpp 31fcb789f5ab907511e868c374c49f7457a33ed3 > src/resource_provider/validation.cpp > d2927227f60ab0d4ae2481ad73a31ee444b48ee0 > src/tests/resource_provider_validation_tests.cpp > f182bff4670318e9de22c2915c5dbb423a74ad6c > > > Diff: https://reviews.apache.org/r/63001/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
