----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63057/#review188257 -----------------------------------------------------------
Patch looks great! Reviews applied: [61805, 61806, 60888, 60889, 60890, 60891, 62142, 62143, 62144, 62145, 63054, 63056, 63057] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Oct. 17, 2017, 12:25 a.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63057/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2017, 12:25 a.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-7305 > https://issues.apache.org/jira/browse/MESOS-7305 > > > Repository: mesos > > > Description > ------- > > This moves tests for the Nested container API found in `api_tests.cpp` > into `agent_container_api_tests.cpp` and refactors the moved tests to: > * Exercise the MesosContainerizer, rather than mocks. > * Parameterize tests to use the Standalone container API or Nested > container API. > * Parameterize tests to exercise different isolator combinations. > > Additionally, the `NestedContainerWaitNotFound` and > `NestedContainerKillNotFound` tests are now combined into > `NestedContainerNotFound`. > > From the `nested_mesos_containerizer_tests.cpp`, the `WaitAfterDestroy` > and `LaunchNestedThreeLevels` were deleted as the same codepaths are now > covered by `NestedContainerLaunch` and `TwoLevelNestedContainerLaunch` > respectively. > > > Diffs > ----- > > src/tests/agent_container_api_tests.cpp PRE-CREATION > src/tests/api_tests.cpp 3d0db3b6c6bfb088a79921c3841ad312dad1ee6a > src/tests/containerizer/nested_mesos_containerizer_tests.cpp > f8b4423de8a468501336acc5ee0c67f181dc65f5 > > > Diff: https://reviews.apache.org/r/63057/diff/1/ > > > Testing > ------- > > make check > sudo src/mesos-tests > > On... > OSX and Ubuntu 16 > > > Thanks, > > Joseph Wu > >
