----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63057/#review190477 -----------------------------------------------------------
Ship it! Ship It! - Jie Yu On Nov. 2, 2017, 4 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63057/ > ----------------------------------------------------------- > > (Updated Nov. 2, 2017, 4 p.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-7305 > https://issues.apache.org/jira/browse/MESOS-7305 > > > Repository: mesos > > > Description > ------- > > This moves tests for the Nested container API found in `api_tests.cpp` > into `agent_container_api_tests.cpp` and refactors the moved tests to: > * Exercise the MesosContainerizer, rather than mocks. > * Parameterize tests to use the Standalone container API or Nested > container API. > * Parameterize tests to exercise different isolator combinations. > > Additionally, the `NestedContainerWaitNotFound` and > `NestedContainerKillNotFound` tests are now combined into > `NestedContainerNotFound`. > > From the `nested_mesos_containerizer_tests.cpp`, the `WaitAfterDestroy` > and `LaunchNestedThreeLevels` were deleted as the same codepaths are now > covered by `NestedContainerLaunch` and `TwoLevelNestedContainerLaunch` > respectively. > > > Diffs > ----- > > src/tests/agent_container_api_tests.cpp PRE-CREATION > src/tests/api_tests.cpp b3efac942f538bcf2594a397d54042028a7aa7a5 > src/tests/containerizer/nested_mesos_containerizer_tests.cpp > fbd2887800ccfd64c8628c5d6fd77a511c8f91d5 > > > Diff: https://reviews.apache.org/r/63057/diff/2/ > > > Testing > ------- > > make check > > On... > OSX and Ubuntu 16 > > > Thanks, > > Joseph Wu > >
