-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62214/
-----------------------------------------------------------

(Updated Oct. 18, 2017, 9:23 a.m.)


Review request for mesos, Benjamin Mahler, Gaston Kleiman, and Kevin Klues.


Changes
-------

Rebase.


Bugs: MESOS-7924
    https://issues.apache.org/jira/browse/MESOS-7924


Repository: mesos


Description (updated)
-------

The linter runs when changes on a JavaScript file are being committed.
We use ESLint with a configuration based on our current JS code base.
The linter and its dependencies (i.e. Node.js) are installed in a
virtual environment using Virtualenv and then Nodeenv.


Diffs (updated)
-----

  src/webui/.eslintrc.js PRE-CREATION 
  src/webui/.gitignore PRE-CREATION 
  src/webui/bootstrap PRE-CREATION 
  src/webui/pip-requirements.txt PRE-CREATION 
  support/mesos-style.py b2fdac9f8f76bdf8d8ede9ad8a056e4bb8c2754c 


Diff: https://reviews.apache.org/r/62214/diff/7/

Changes: https://reviews.apache.org/r/62214/diff/6-7/


Testing (updated)
-------

```
$ make check
```

Following this commit, I have also tried to commit a change on a JavaScript 
file and checked that ESLinter was correctly running.


Thanks,

Armand Grillet

Reply via email to