> On Oct. 19, 2017, 5:51 p.m., Jie Yu wrote: > > src/csi/utils.cpp > > Lines 25 (patched) > > <https://reviews.apache.org/r/63060/diff/2/?file=1859642#file1859642line25> > > > > Do you need `csi::` prefix?
Yes. `Version` is also defined in stout. - Chun-Hung ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63060/#review188712 ----------------------------------------------------------- On Oct. 17, 2017, 4:50 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63060/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2017, 4:50 a.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos > > > Description > ------- > > This patch adds some helper structures for CSI capabilities, comparison > and output operators for `csi::Version` in the `::csi` namespace so > `stringify()` can find it through ADL. Also, it exposes `::csi` in > `mesos::csi` in `spec.hpp` instead of `client.hpp`. > > > Diffs > ----- > > src/Makefile.am 085ff3b820693c9ef0115a74d72b0d87f158a887 > src/csi/client.hpp df674e17260519f983367f7c01f1057a75076238 > src/csi/spec.hpp 60e40e05d81c9bf649459e29479838dd80daa3aa > src/csi/utils.hpp PRE-CREATION > src/csi/utils.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/63060/diff/2/ > > > Testing > ------- > > make > > > Thanks, > > Chun-Hung Hsiao > >
